Repository navigation
fix: ensure version not is checked if exec_file is provided - #4138
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the MAPDL version was not being checked when a custom executable file path was provided via the exec_file parameter. The fix ensures that version validation occurs consistently regardless of how the executable is specified.
- Added conditional check to only call
get_version()whenexec_fileis provided - Enhanced documentation for the
exec_fileparameter with platform-specific examples - Improved code formatting for better readability
…ps://github.com/ansys/pymapdl into fix/skipping-version-check-when-using-exec_file
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4138 +/- ##
==========================================
- Coverage 91.34% 91.22% -0.13%
==========================================
Files 189 189
Lines 15697 15698 +1
==========================================
- Hits 14339 14321 -18
- Misses 1358 1377 +19 🚀 New features to boost your workflow:
|
Collaborator
Author
|
@pyansys-ci-bot LGTM. |
4 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
As the title.
Issue linked
Close #4134
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)