Skip to content

fix: ensure version not is checked if exec_file is provided - #4138

Merged
germa89 merged 4 commits into
mainfrom
fix/skipping-version-check-when-using-exec_file
Aug 4, 2025
Merged

germa89 merged 4 commits into
mainfrom
fix/skipping-version-check-when-using-exec_file

Conversation

@germa89

@germa89 germa89 commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator

Description

As the title.

Issue linked

Close #4134

Checklist

Copilot AI review requested due to automatic review settings August 4, 2025 08:00
@germa89
germa89 requested a review from a team as a code owner August 4, 2025 08:00
@germa89
germa89 enabled auto-merge (squash) August 4, 2025 08:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a bug where the MAPDL version was not being checked when a custom executable file path was provided via the exec_file parameter. The fix ensures that version validation occurs consistently regardless of how the executable is specified.

  • Added conditional check to only call get_version() when exec_file is provided
  • Enhanced documentation for the exec_file parameter with platform-specific examples
  • Improved code formatting for better readability

Comment thread src/ansys/mapdl/core/launcher.py Outdated
@github-actions github-actions Bot added the bug Issue, problem or error in PyMAPDL label Aug 4, 2025
@codecov

codecov Bot commented Aug 4, 2025 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.22%. Comparing base (3ab601a) to head (b60ea0a).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4138      +/-   ##
==========================================
- Coverage   91.34%   91.22%   -0.13%     
==========================================
  Files         189      189              
  Lines       15697    15698       +1     
==========================================
- Hits        14339    14321      -18     
- Misses       1358     1377      +19     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@germa89 germa89 changed the title fix: ensure version is checked if exec_file is provided fix: ensure version not is checked if exec_file is provided Aug 4, 2025
@germa89

germa89 commented Aug 4, 2025

Copy link
Copy Markdown
Collaborator Author

@pyansys-ci-bot LGTM.

@pyansys-ci-bot pyansys-ci-bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approving this PR because germa89 said so in here 😬

LGTM

@germa89
germa89 merged commit c1ac82c into main Aug 4, 2025
@germa89
germa89 deleted the fix/skipping-version-check-when-using-exec_file branch August 4, 2025 09:29
@germa89 germa89 mentioned this pull request Aug 8, 2025
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Issue, problem or error in PyMAPDL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Version should not be checked when using exec_path

3 participants