refactor: streamline environment variable usage in migrator workflow - #4141
Merged
Conversation
germa89
enabled auto-merge (squash)
August 4, 2025 17:43
github-actions
Bot
added
CI/CD
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request refactors the migrator workflow to use environment variables instead of direct GitHub context expressions within JavaScript code blocks. The changes improve consistency and maintainability by centralizing environment variable access patterns throughout the workflow.
Key changes:
- Replaced inline GitHub context expressions with environment variables in JavaScript script blocks
- Standardized shell script variable usage to use
${VAR}syntax instead of GitHub expressions - Added environment variable definitions at the step level for better organization
Collaborator
Author
|
@pyansys-ci-bot LGTM |
germa89
disabled auto-merge
August 4, 2025 17:46
This comment was marked as duplicate.
This comment was marked as duplicate.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4141 +/- ##
==========================================
+ Coverage 91.30% 91.35% +0.04%
==========================================
Files 189 189
Lines 15698 15701 +3
==========================================
+ Hits 14333 14343 +10
+ Misses 1365 1358 -7 🚀 New features to boost your workflow:
|
klmcadams
approved these changes
Aug 4, 2025
Revathyvenugopal162
approved these changes
Aug 5, 2025
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
Co-authored-by: Revathy Venugopal <104772255+Revathyvenugopal162@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As the title.
Issue linked
Internal
Checklist
draftif it is not ready to be reviewed yet.feat: adding new MAPDL command)