Skip to content

REFACTOR: Remove f-string without placeholders and specify exception type.#1011

Merged
dipinknair merged 4 commits into
mainfrom
maint/except
Jan 2, 2025
Merged

REFACTOR: Remove f-string without placeholders and specify exception type.#1011
dipinknair merged 4 commits into
mainfrom
maint/except

Conversation

@MaxJPRey

Copy link
Copy Markdown
Contributor

Remove usage of bare except.

Remove f-string without placeholders.

@MaxJPRey MaxJPRey requested a review from a team as a code owner December 26, 2024 13:49
@MaxJPRey MaxJPRey requested a review from dipinknair December 26, 2024 13:49
@github-actions github-actions Bot added the maintenance Package and maintenance related label Dec 26, 2024
@codecov

codecov Bot commented Dec 26, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 83.76%. Comparing base (a78f5e3) to head (5c66635).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1011      +/-   ##
==========================================
- Coverage   87.38%   83.76%   -3.63%     
==========================================
  Files          35       35              
  Lines        2260     2260              
==========================================
- Hits         1975     1893      -82     
- Misses        285      367      +82     

@MaxJPRey MaxJPRey changed the title MAINT: Remove f-string without placeholders and specify exception type. REFACTOR: Remove f-string without placeholders and specify exception type. Dec 26, 2024
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Dec 26, 2024

@dipinknair dipinknair left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxJPRey. LGTM.

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MaxJPRey - much appreciated!

@dipinknair dipinknair merged commit 6b95f2a into main Jan 2, 2025
@dipinknair dipinknair deleted the maint/except branch January 2, 2025 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants