Skip to content

feat: add globals kwarg to app and adjust ideconfig behavior#1017

Merged
klmcadams merged 27 commits into
mainfrom
autocomplete
Feb 12, 2025
Merged

feat: add globals kwarg to app and adjust ideconfig behavior#1017
klmcadams merged 27 commits into
mainfrom
autocomplete

Conversation

@klmcadams

Copy link
Copy Markdown
Contributor
  • Add globals kwarg to App class
  • Import globals if the app is initialized

ideconfig

  • Raise an exception if the revision number is less than the minimum version in ansys-mechanical-stubs
  • Raise a warning if the revision number is greater than the maximum version in ansys-mechanical-stubs. Use the max version to print the autocomplete settings

@klmcadams klmcadams requested a review from a team as a code owner January 3, 2025 18:45
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jan 3, 2025
Comment thread src/ansys/mechanical/core/embedding/app.py
Comment thread src/ansys/mechanical/core/embedding/app.py Outdated
Comment thread src/ansys/mechanical/core/embedding/global_importer.py
@koubaa

koubaa commented Jan 3, 2025

Copy link
Copy Markdown
Contributor

Need to update examples. one should use the new globals() argument. Another should avoid globals entirely and import the types manually after constructing the app instance

@klmcadams klmcadams marked this pull request as draft January 3, 2025 19:31
@codecov

codecov Bot commented Jan 30, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 98.21429% with 1 line in your changes missing coverage. Please review.

Project coverage is 79.43%. Comparing base (7544b20) to head (bae09e9).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1017      +/-   ##
==========================================
- Coverage   87.16%   79.43%   -7.73%     
==========================================
  Files          41       43       +2     
  Lines        2835     2854      +19     
==========================================
- Hits         2471     2267     -204     
- Misses        364      587     +223     

@github-actions github-actions Bot added the maintenance Package and maintenance related label Feb 5, 2025
@github-actions github-actions Bot added the ci/cd Involves the GitHub workflow files label Feb 5, 2025
@klmcadams klmcadams marked this pull request as ready for review February 6, 2025 00:10
@klmcadams klmcadams requested a review from koubaa February 6, 2025 17:21
@klmcadams klmcadams requested a review from a team February 7, 2025 14:14
Comment thread .github/workflows/ci_cd.yml
Comment thread src/ansys/mechanical/core/embedding/app.py Outdated
Comment thread src/ansys/mechanical/core/embedding/app.py Outdated
Comment thread src/ansys/mechanical/core/embedding/app.py Outdated
@klmcadams klmcadams requested a review from koubaa February 12, 2025 16:33
@klmcadams klmcadams merged commit 8879d7c into main Feb 12, 2025
@klmcadams klmcadams deleted the autocomplete branch February 12, 2025 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants