Skip to content

FEAT: Rpyc integration - #1055

Merged
dipinknair merged 31 commits into
mainfrom
feat/rpc-rpyc
Jan 29, 2025
Merged

dipinknair merged 31 commits into
mainfrom
feat/rpc-rpyc

Conversation

@dipinknair

@dipinknair dipinknair commented Jan 20, 2025 •

Copy link
Copy Markdown
Contributor

Implement remote calls for embedded app

@github-actions github-actions Bot added dependencies Related with project dependencies enhancement New features or code improvements labels Jan 20, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jan 20, 2025
@github-actions github-actions Bot added maintenance Package and maintenance related ci/cd Involves the GitHub workflow files labels Jan 20, 2025

@dipinknair dipinknair left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@koubaa Using Background App.

Comment thread src/ansys/mechanical/core/embedding/background.py
Comment thread tests/conftest.py Outdated
Comment thread tests/test_mechanical.py Outdated
@codecov

codecov Bot commented Jan 22, 2025 •

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 44.61538% with 216 lines in your changes missing coverage. Please review.

Project coverage is 81.27%. Comparing base (bbbd6c3) to head (454e9d9).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (44.61%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1055      +/-   ##
==========================================
- Coverage   87.34%   81.27%   -6.07%     
==========================================
  Files          36       40       +4     
  Lines        2362     2751     +389     
==========================================
+ Hits         2063     2236     +173     
- Misses        299      515     +216     

@dipinknair
dipinknair marked this pull request as ready for review January 27, 2025 16:26
@dipinknair
dipinknair requested a review from a team as a code owner January 27, 2025 16:26
Comment thread .github/workflows/ci_cd.yml Outdated
Comment thread .github/workflows/ci_cd.yml Outdated
Comment thread .github/workflows/ci_cd.yml Outdated
@dipinknair
dipinknair merged commit 2dd4235 into main Jan 29, 2025
@dipinknair
dipinknair deleted the feat/rpc-rpyc branch January 29, 2025 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Involves the GitHub workflow files dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants