Skip to content

feat: Create option for PyPIM to be installed separately#1060

Merged
klmcadams merged 13 commits into
mainfrom
feat/pim-dependency-option
Jan 24, 2025
Merged

feat: Create option for PyPIM to be installed separately#1060
klmcadams merged 13 commits into
mainfrom
feat/pim-dependency-option

Conversation

@klmcadams
Copy link
Copy Markdown
Collaborator

  • Do not install PyPIM by default for launch_mechanical
  • User has to pip install ansys-mechanical-core[pim] if they would like to use pim with launch_mechanical

Closes #419

@klmcadams klmcadams requested a review from a team as a code owner January 23, 2025 18:15
@github-actions github-actions Bot added maintenance Package and maintenance related dependencies Related with project dependencies enhancement New features or code improvements labels Jan 23, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.56%. Comparing base (976b288) to head (1087571).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1060      +/-   ##
==========================================
- Coverage   87.67%   87.56%   -0.11%     
==========================================
  Files          36       36              
  Lines        2344     2348       +4     
==========================================
+ Hits         2055     2056       +1     
- Misses        289      292       +3     

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jan 23, 2025
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just a few enhancements

Comment thread src/ansys/mechanical/core/mechanical.py Outdated
Comment thread src/ansys/mechanical/core/pool.py Outdated
Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@klmcadams klmcadams merged commit 868afe8 into main Jan 24, 2025
@klmcadams klmcadams deleted the feat/pim-dependency-option branch January 24, 2025 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

launch_mechanical has a version argument that is only supported if pypim is configured

4 participants