Skip to content

FIX: Add option on rpc server for accepting multiple services#1074

Merged
dipinknair merged 12 commits into
mainfrom
fix/rpc
Mar 4, 2025
Merged

FIX: Add option on rpc server for accepting multiple services#1074
dipinknair merged 12 commits into
mainfrom
fix/rpc

Conversation

@dipinknair

@dipinknair dipinknair commented Jan 29, 2025

Copy link
Copy Markdown
Contributor

This way user can call their own servicemethods with DefaultServiceMethods for a custom server

server = MechanicalEmbeddedServer(
        port=_port,
        version=_version,
        impl=[DefaultServiceMethods, ServiceMethods],
    )

or

server = MechanicalEmbeddedServer(
        port=_port,
        version=_version,
        impl=ServiceMethods,
    )

@dipinknair dipinknair requested a review from a team as a code owner January 29, 2025 22:49
@dipinknair dipinknair requested a review from koubaa January 29, 2025 22:49
@github-actions github-actions Bot added the bug Something isn't working label Jan 29, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jan 29, 2025
@codecov

codecov Bot commented Jan 29, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.64%. Comparing base (d3275ef) to head (e3b7ad5).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1074   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          39       39           
  Lines        2501     2501           
=======================================
  Hits         2167     2167           
  Misses        334      334           

Comment thread src/ansys/mechanical/core/embedding/rpc/server.py
@dipinknair dipinknair requested a review from koubaa February 24, 2025 13:50
@codacy-production

codacy-production Bot commented Mar 3, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 884c9761
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (884c976) Report Missing Report Missing Report Missing
Head commit (e3b7ad5) 2501 2167 86.65%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1074) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@dipinknair dipinknair merged commit 8ac1962 into main Mar 4, 2025
@dipinknair dipinknair deleted the fix/rpc branch March 4, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants