Skip to content

FIX: Embedding rpc server shutdown#1088

Merged
dipinknair merged 7 commits into
mainfrom
fix/rpc-exit
Feb 10, 2025
Merged

FIX: Embedding rpc server shutdown#1088
dipinknair merged 7 commits into
mainfrom
fix/rpc-exit

Conversation

@dipinknair

Copy link
Copy Markdown
Contributor

Fixes #1077

@dipinknair
dipinknair requested a review from a team as a code owner February 7, 2025 16:41
@github-actions github-actions Bot added the bug Something isn't working label Feb 7, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 7, 2025
@dipinknair
dipinknair requested a review from koubaa February 7, 2025 16:44
Comment thread tests/conftest.py
@dipinknair
dipinknair requested a review from koubaa February 10, 2025 17:51
Comment thread tests/conftest.py Outdated
Comment thread tests/conftest.py Outdated
@codecov

codecov Bot commented Feb 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.65217% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.05%. Comparing base (4c5d966) to head (85ba9b3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
+ Coverage   81.37%   87.05%   +5.67%     
==========================================
  Files          40       41       +1     
  Lines        2755     2835      +80     
==========================================
+ Hits         2242     2468     +226     
+ Misses        513      367     -146     

@dipinknair dipinknair changed the title FIX: Emedding rpc server shutdown FIX: Embedding rpc server shutdown Feb 10, 2025
@dipinknair
dipinknair merged commit 7544b20 into main Feb 10, 2025
@dipinknair
dipinknair deleted the fix/rpc-exit branch February 10, 2025 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Crash on shutting down rpc server

3 participants