Skip to content

FIX: Remove unnecessary prints from embedding rpc#1090

Merged
dipinknair merged 9 commits into
mainfrom
fix/rpyc-prints
Feb 25, 2025
Merged

FIX: Remove unnecessary prints from embedding rpc#1090
dipinknair merged 9 commits into
mainfrom
fix/rpyc-prints

Conversation

@dipinknair

@dipinknair dipinknair commented Feb 10, 2025

Copy link
Copy Markdown
Contributor
  • Improves how clients waiting till server is ready
  • removes some unwanted prints

@github-actions github-actions Bot added the bug Something isn't working label Feb 10, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 10, 2025
Comment thread src/ansys/mechanical/core/embedding/rpc/server.py
@dipinknair dipinknair changed the title FEAT: Remove unnecessary prints and add logging option FIX: Remove unnecessary prints from embedding rpc Feb 10, 2025
@dipinknair dipinknair marked this pull request as ready for review February 10, 2025 20:49
@dipinknair dipinknair requested review from a team as code owners February 10, 2025 20:49
@dipinknair dipinknair requested a review from koubaa February 10, 2025 20:49
@codecov

codecov Bot commented Feb 10, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 76.92308% with 6 lines in your changes missing coverage. Please review.

Project coverage is 81.47%. Comparing base (dad2a2c) to head (ffb8d5f).

❌ Your patch check has failed because the patch coverage (76.92%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1090      +/-   ##
==========================================
+ Coverage   79.74%   81.47%   +1.72%     
==========================================
  Files          43       43              
  Lines        2854     2856       +2     
==========================================
+ Hits         2276     2327      +51     
+ Misses        578      529      -49     

Comment thread src/ansys/mechanical/core/embedding/rpc/client.py Outdated
@dipinknair dipinknair requested a review from RobPasMue February 24, 2025 16:50
@dipinknair dipinknair enabled auto-merge (squash) February 25, 2025 15:18
@dipinknair dipinknair merged commit d8ac7ab into main Feb 25, 2025
@dipinknair dipinknair deleted the fix/rpyc-prints branch February 25, 2025 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants