Skip to content

FEAT: add logging for app#1091

Merged
dipinknair merged 8 commits into
mainfrom
feat/embedding_logger
Mar 3, 2025
Merged

FEAT: add logging for app#1091
dipinknair merged 8 commits into
mainfrom
feat/embedding_logger

Conversation

@dipinknair

@dipinknair dipinknair commented Feb 14, 2025

Copy link
Copy Markdown
Collaborator
INFO -  -  app - log_info - Starting Mechanical Application
INFO -  -  initializer - _get_latest_default_version - Existing Mechanical versions found: [232, 241, 242, 251, 252, 252]
WARNING -  -  initializer - _get_latest_default_version - Multiple versions of Mechanical found! Using latest version 252 ...

@github-actions github-actions Bot added the enhancement New features or code improvements label Feb 14, 2025
@codecov

codecov Bot commented Feb 14, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 55.55556% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.63%. Comparing base (4e70d7b) to head (89144e7).
Report is 2 commits behind head on main.

❌ Your patch status has failed because the patch coverage (55.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1091      +/-   ##
==========================================
+ Coverage   79.90%   80.63%   +0.73%     
==========================================
  Files          43       43              
  Lines        2856     2908      +52     
==========================================
+ Hits         2282     2345      +63     
+ Misses        574      563      -11     

@dipinknair dipinknair marked this pull request as ready for review February 24, 2025 17:20
@dipinknair dipinknair requested a review from a team as a code owner February 24, 2025 17:20
@dipinknair dipinknair requested a review from koubaa February 24, 2025 17:22
@dipinknair dipinknair changed the title DRAFT: add logging for app FEAT: add logging for app Feb 24, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Feb 24, 2025
Comment thread src/ansys/mechanical/core/embedding/app.py Outdated
@codacy-production

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for 557b4251 55.56%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (557b425) Report Missing Report Missing Report Missing
Head commit (89144e7) 2908 2345 80.64%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1091) 27 15 55.56%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@dipinknair dipinknair merged commit 5411be1 into main Mar 3, 2025
@dipinknair dipinknair deleted the feat/embedding_logger branch March 3, 2025 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants