Conversation
Refactor the fixtures to allow checking process before each test Move the test attributes to the client classes
return the process object raise an Exception when batch=False don't create a copy of the environment
…into rpc-bg-switch
klmcadams
left a comment
There was a problem hiding this comment.
I changed some variable names to use snake_case instead of camelCase and used pathlib instead of os (if possible). Also, I'd recommend changing functions & variables named f to something more descriptive (for example, service._exit_f, stop_f, start_f)
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more |
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (55.55%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1122 +/- ##
==========================================
+ Coverage 87.03% 87.13% +0.09%
==========================================
Files 39 39
Lines 2507 2510 +3
==========================================
+ Hits 2182 2187 +5
+ Misses 325 323 -2 🚀 New features to boost your workflow:
|
Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
…into rpc-bg-switch
Refactor python backend for rpc.
Add a hidden option to control which of the two threads is the main thread: rpc server, mechanical app. Change the default to mechanical app (in case the stability issue has to do with the background app)