Skip to content

CHORE: Change viz to graphics#1133

Merged
dipinknair merged 4 commits into
mainfrom
chore/graphics
Apr 2, 2025
Merged

CHORE: Change viz to graphics#1133
dipinknair merged 4 commits into
mainfrom
chore/graphics

Conversation

@dipinknair
Copy link
Copy Markdown
Collaborator

fixes #1132

@github-actions github-actions Bot added documentation Improvements or additions to documentation dependencies Related with project dependencies labels Mar 31, 2025
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Mar 31, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 16.67%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (034af3c) 2510 2187 87.13%
Head commit (0e005ee) 2510 (+0) 2187 (+0) 87.13% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1133) 6 1 16.67%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 31, 2025

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.13%. Comparing base (034af3c) to head (0e005ee).
Report is 1 commits behind head on main.

❌ Your patch status has failed because the patch coverage (16.66%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1133   +/-   ##
=======================================
  Coverage   87.13%   87.13%           
=======================================
  Files          39       39           
  Lines        2510     2510           
=======================================
  Hits         2187     2187           
  Misses        323      323           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if you really needed to rename the subpackage from "viz" to "graphics" but I prefer it that way. Let's have this merged asap @dipinknair

Comment thread pyproject.toml
@dipinknair dipinknair marked this pull request as ready for review April 2, 2025 02:11
@dipinknair dipinknair requested a review from a team as a code owner April 2, 2025 02:11
@dipinknair dipinknair enabled auto-merge (squash) April 2, 2025 02:11
@dipinknair dipinknair merged commit 54a331f into main Apr 2, 2025
@dipinknair dipinknair deleted the chore/graphics branch April 2, 2025 02:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change viz target for graphics target

3 participants