Skip to content

fix: Appdata test maintenance and pyvista deprecation warning#1152

Merged
klmcadams merged 15 commits into
mainfrom
appdata-test
May 1, 2025
Merged

fix: Appdata test maintenance and pyvista deprecation warning#1152
klmcadams merged 15 commits into
mainfrom
appdata-test

Conversation

@koubaa

@koubaa koubaa commented Apr 28, 2025

Copy link
Copy Markdown
Contributor

Need to use private appdata so that the user's last selection for "ShowTriad" does not affect the test execution.

Also fix an issue where appdata folders were not being deleted by shutil.

@koubaa
koubaa requested a review from a team as a code owner April 28, 2025 12:37
@koubaa
koubaa requested a review from klmcadams April 28, 2025 12:37
@koubaa koubaa changed the title Appdata test maintenance fix: Appdata test maintenance Apr 28, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Apr 28, 2025
@codacy-production

codacy-production Bot commented Apr 28, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.09% (target: -1.00%) 95.83%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (45a53f6) 2517 2192 87.09%
Head commit (a817889) 2520 (+3) 2197 (+5) 87.18% (+0.09%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1152) 24 23 95.83%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov

codecov Bot commented Apr 28, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 95.83333% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.18%. Comparing base (45a53f6) to head (a817889).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1152      +/-   ##
==========================================
+ Coverage   87.08%   87.18%   +0.09%     
==========================================
  Files          39       39              
  Lines        2517     2520       +3     
==========================================
+ Hits         2192     2197       +5     
+ Misses        325      323       -2     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Comment thread src/ansys/mechanical/core/embedding/graphics/embedding_plotter.py
@klmcadams klmcadams changed the title fix: Appdata test maintenance fix: Appdata test maintenance and pyvista deprecation warning Apr 29, 2025
@github-actions github-actions Bot added maintenance Package and maintenance related ci/cd Involves the GitHub workflow files labels May 1, 2025
@klmcadams
klmcadams enabled auto-merge (squash) May 1, 2025 13:43
@klmcadams
klmcadams merged commit e82df19 into main May 1, 2025
@klmcadams
klmcadams deleted the appdata-test branch May 1, 2025 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants