fix: add workaround for windows store - #1153
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (25.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1153 +/- ##
==========================================
- Coverage 87.08% 86.79% -0.30%
==========================================
Files 39 39
Lines 2517 2536 +19
==========================================
+ Hits 2192 2201 +9
- Misses 325 335 +10 🚀 New features to boost your workflow:
|
|
@klmcadams Are you familiar with this quarto error in the doc build? |
|
@koubaa Is it possible to add tests for this or would we have to download Python from the Windows store? |
Yes, we will test the entire metapackage against the Python distribution provided by Windows store. |
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesFootnotes
|
| dependency. | ||
|
|
||
| PyMechanical loads the embedding library which automatically sets | ||
| these Paths, but this uses the PATH environment variable which doesn't |
There was a problem hiding this comment.
| these Paths, but this uses the PATH environment variable which doesn't | |
| these paths, but this uses the PATH environment variable which doesn't |
The windows store python uses windows secure DLL loading (via the Win32 API
SetDefaultDllDirectories), which is not enabled in the python.org distribution. PyMechanical internally changes the processPATHenvironment variable for DLL loading, which does not work if secure DLL loading is used.A future version of Mechanical may support secure DLL loading, but for the current releases PyMechanical can work around the issue by calling
os.add_dll_directory()Fixes #1136