fix: Update globals when BUILDING_GALLERY is True #1155
Merged
Conversation
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1155 +/- ##
==========================================
- Coverage 86.75% 86.40% -0.35%
==========================================
Files 39 39
Lines 2536 2537 +1
==========================================
- Hits 2200 2192 -8
- Misses 336 345 +9 🚀 New features to boost your workflow:
|
…echanical into maint/globals-function
koubaa
reviewed
May 5, 2025
koubaa
reviewed
May 5, 2025
klmcadams
commented
May 7, 2025
koubaa
reviewed
May 7, 2025
koubaa
approved these changes
May 7, 2025
koubaa
reviewed
May 7, 2025
koubaa
requested changes
May 7, 2025
koubaa
left a comment
Contributor
There was a problem hiding this comment.
Remove the unused code in run_embedded_app.py
koubaa
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update globals when the globals kwarg is provided and BUILDING_GALLERY is True