Skip to content

fix: Update globals when BUILDING_GALLERY is True #1155

Merged
klmcadams merged 14 commits into
mainfrom
maint/globals-function
May 8, 2025
Merged

fix: Update globals when BUILDING_GALLERY is True #1155
klmcadams merged 14 commits into
mainfrom
maint/globals-function

Conversation

@klmcadams

Copy link
Copy Markdown
Contributor

Update globals when the globals kwarg is provided and BUILDING_GALLERY is True

@klmcadams klmcadams requested a review from a team as a code owner May 2, 2025 19:43
@github-actions github-actions Bot added the maintenance Package and maintenance related label May 2, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label May 2, 2025
@codacy-production

codacy-production Bot commented May 2, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.35% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (e23b76d) 2536 2200 86.75%
Head commit (3a54974) 2537 (+1) 2192 (-8) 86.40% (-0.35%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1155) 2 2 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov

codecov Bot commented May 2, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.40%. Comparing base (e23b76d) to head (3a54974).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1155      +/-   ##
==========================================
- Coverage   86.75%   86.40%   -0.35%     
==========================================
  Files          39       39              
  Lines        2536     2537       +1     
==========================================
- Hits         2200     2192       -8     
- Misses        336      345       +9     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@klmcadams klmcadams requested a review from koubaa May 2, 2025 20:10
Comment thread tests/scripts/run_embedded_app.py Outdated
Comment thread tests/scripts/run_embedded_app.py Outdated
Comment thread tests/scripts/run_embedded_app.py Outdated
@klmcadams klmcadams requested a review from koubaa May 7, 2025 15:47
Comment thread tests/scripts/run_embedded_app.py Outdated
Comment thread tests/scripts/run_embedded_app.py Outdated

@koubaa koubaa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the unused code in run_embedded_app.py

@github-actions github-actions Bot added the ci/cd Involves the GitHub workflow files label May 8, 2025
@klmcadams klmcadams enabled auto-merge (squash) May 8, 2025 15:56
@klmcadams klmcadams merged commit 4ddca27 into main May 8, 2025
54 of 55 checks passed
@klmcadams klmcadams deleted the maint/globals-function branch May 8, 2025 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants