Skip to content

fix: Change the name of the warnings.py file in embedding - #1209

Merged
klmcadams merged 3 commits into
mainfrom
fix/warnings-err
Jun 26, 2025
Merged

fix: Change the name of the warnings.py file in embedding#1209
klmcadams merged 3 commits into
mainfrom
fix/warnings-err

Conversation

@klmcadams

Copy link
Copy Markdown
Contributor

Renamed warnings.py to mechanical_warnings.py due to the error described in #1173. The file being named warnings.py was interfering with the warnings.warn functionality when psutil was imported. Thanks @RobPasMue for helping me figure this out!

@klmcadams
klmcadams requested a review from a team as a code owner June 26, 2025 15:11
@github-actions github-actions Bot added the bug Something isn't working label Jun 26, 2025
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 26, 2025

@RobPasMue RobPasMue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! My pleasure :)

@codacy-production

codacy-production Bot commented Jun 26, 2025

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%) 100.00%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (0f241f6) 2537 2193 86.44%
Head commit (b09fd28) 2537 (+0) 2193 (+0) 86.44% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#1209) 1 1 100.00%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov

codecov Bot commented Jun 26, 2025

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.44%. Comparing base (0f241f6) to head (b09fd28).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1209   +/-   ##
=======================================
  Coverage   86.44%   86.44%           
=======================================
  Files          39       39           
  Lines        2537     2537           
=======================================
  Hits         2193     2193           
  Misses        344      344           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@klmcadams
klmcadams enabled auto-merge (squash) June 26, 2025 15:50
@klmcadams
klmcadams merged commit a955d3b into main Jun 26, 2025
@klmcadams
klmcadams deleted the fix/warnings-err branch June 26, 2025 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants