FEAT: Add option for pep8 aliases in binding - #1234
Conversation
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (80.00%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #1234 +/- ##
==========================================
- Coverage 86.40% 86.39% -0.01%
==========================================
Files 39 39
Lines 2537 2544 +7
==========================================
+ Hits 2192 2198 +6
- Misses 345 346 +1 🚀 New features to boost your workflow:
|
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferences |
koubaa
left a comment
There was a problem hiding this comment.
the opt-out section looks wrong to me
This pull request refactors the
_bind_assembly_for_explicit_interfacefunction to make it more flexible and updates its usage in theinitializefunction. The refactored function now supports additional options for binding assemblies, including enabling PEP 8 aliases.Refactoring of
_bind_assembly_for_explicit_interface:_bind_assembly_for_explicit_interfaceto_bind_assemblyand added two optional parameters:explicit_interfaceandpep8_aliases. This allows the function to handle both explicit interface implementation and PEP 8 aliasing.AllowExplicitInterfaceImplementationandPep8Aliasesbased on the new parameters.Updates to
initializefunction:_bind_assembly_for_explicit_interfacewith_bind_assemblyand passedTruefor bothexplicit_interfaceandpep8_aliasesarguments to enable these features for the "Ansys.ACT.WB1" assembly.Usage: