Run all embedding tests & fix appdata tests#433
Merged
Conversation
klmcadams
commented
Oct 3, 2023
klmcadams
commented
Contributor
- Fixed normal_appdata and private_appdata tests
- Allow all embedding tests to run in workflow
github-actions
Bot
added
maintenance
klmcadams
changed the title
…pymechanical into fix/private-appdata-tests
klmcadams
commented
Oct 3, 2023
koubaa
approved these changes
Oct 3, 2023
koubaa
left a comment
koubaa
left a comment
Contributor
There was a problem hiding this comment.
approving.. but I'm not sure I understand what was wrong with the appdata tests
Contributor
Author
Whenever we would run the appdata tests in the container, they would fail because of the crash on shutdown in Linux, so it was returning a signal abort and failing them (I had previously used subprocess.check_call). I adjusted them to be similar to the tests/embedding/test_logger.py tests, where they look for a specific string in the stdout to make sure it's working correctly instead |
Contributor
|
@klmcadams oh! makes sense, thanks! |
Contributor
Author
No problem! |
…pymechanical into fix/private-appdata-tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.