Skip to content

Fix hanging embedding tests #498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
klmcadams merged 4 commits into from
Nov 20, 2023
Merged

Fix hanging embedding tests #498

klmcadams merged 4 commits into from
Nov 20, 2023

Conversation

@klmcadams
Copy link
Collaborator

@klmcadams klmcadams commented Nov 17, 2023 •
edited
Loading

Change Popen.wait() to Popen.communicate() due to this warning: https://docs.python.org/2/library/subprocess.html#subprocess.Popen.wait

Removed max_parallel in embedding test section

Closes #460

@github-actions github-actions bot added the bug Something isn't working label Nov 17, 2023
@github-actions github-actions bot added maintenance Package and maintenance related CI/CD labels Nov 17, 2023
@klmcadams klmcadams enabled auto-merge (squash) November 17, 2023 17:14
@klmcadams klmcadams merged commit 2487ef6 into main Nov 20, 2023
@klmcadams klmcadams deleted the fix/hanging-embedding-tests branch November 20, 2023 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@RobPasMue RobPasMue RobPasMue approved these changes

@koubaa koubaa Awaiting requested review from koubaa

Assignees

No one assigned

Labels

bug Something isn't working maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

workflow steps hang

3 participants

@klmcadams @RobPasMue