Skip to content

Conversation

@dipinknair
Copy link
Collaborator

Use get_mechanical_path instead of find_mechanical in remote_session_launch tests

@github-actions github-actions bot added the bug Something isn't working label Apr 8, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 8, 2024
@dipinknair dipinknair force-pushed the fix/launch-session-test branch from 0684fd7 to 90238d9 Compare April 8, 2024 16:13
@dipinknair dipinknair marked this pull request as ready for review April 8, 2024 16:16
@dipinknair dipinknair requested a review from a team as a code owner April 8, 2024 16:16
@koubaa
Copy link
Collaborator

koubaa commented Apr 8, 2024

@dipinknair which issue is this associated with?

@dipinknair
Copy link
Collaborator Author

dipinknair commented Apr 8, 2024

@koubaa

Came across this issue while debugging remote_session_launch test failures locally. Since find_mechanical() does not check config.txt , some test were failing because of not able to retrieve path.

@koubaa
Copy link
Collaborator

koubaa commented Apr 8, 2024

@dipinknair we run on containers that put mechanical under /install/ansys_inc/vNnn. So find_mechanical should work there. Do you know why it didn't?

@dipinknair
Copy link
Collaborator Author

dipinknair commented Apr 8, 2024

@dipinknair we run on containers that put mechanical under /install/ansys_inc/vNnn. So find_mechanical should work there. Do you know why it didn't?

This is to facilitate testing locally so that we can debug further issues that we see in tests. This is not a fix for the test failures happening in github runners but fix to run the test locally since Pool test are also using find_mechanical. find_mechanical works fine in github runners.

@koubaa
Copy link
Collaborator

koubaa commented Apr 8, 2024

@dipinknair in that case I suggest leaving a fallback to find the path if there's nothing in the config, otherwise this will require setting the path before the test can run.

@dipinknair
Copy link
Collaborator Author

dipinknair commented Apr 8, 2024

@dipinknair in that case I suggest leaving a fallback to find the path if there's nothing in the config, otherwise this will require setting the path before the test can run.

get_mechanical_path takes care that and find arg set always true for this function which falls back to find mechanical if no path found from the config file

@dipinknair dipinknair merged commit 58853e9 into main Apr 8, 2024
@dipinknair dipinknair deleted the fix/launch-session-test branch April 8, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants