Skip to content

ci: Add vulnerability check#709

Merged
dipinknair merged 9 commits intomainfrom
feat/vulnerability
Oct 8, 2024
Merged

ci: Add vulnerability check#709
dipinknair merged 9 commits intomainfrom
feat/vulnerability

Conversation

@dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Apr 16, 2024

This failure of the action means mechanical has vulnerabilities which we should look into @ansys/pymechanical-maintainers

@github-actions github-actions bot added maintenance Package and maintenance related CI/CD enhancement New features or code improvements labels Apr 16, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 16, 2024
@codecov
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.04%. Comparing base (ab6e2cf) to head (83d7d38).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #709   +/-   ##
=======================================
  Coverage   81.04%   81.04%           
=======================================
  Files          35       35           
  Lines        2232     2232           
=======================================
  Hits         1809     1809           
  Misses        423      423           

@dipinknair dipinknair closed this May 16, 2024
@dipinknair dipinknair deleted the feat/vulnerability branch June 10, 2024 17:05
@dipinknair dipinknair restored the feat/vulnerability branch October 4, 2024 15:04
@dipinknair dipinknair reopened this Oct 4, 2024
@github-actions github-actions bot added the ci/cd Involves the GitHub workflow files label Oct 4, 2024
@dipinknair dipinknair changed the title Feat: Add vulnerability check [TEST] Add vulnerability check Oct 4, 2024
Comment on lines 80 to 84
check-vulnerabilities:
name: "Check library vulnerabilities (development mode)"
if: github.ref != 'refs/heads/main'
runs-on: ubuntu-latest
steps:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also the main mode

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the bot has admin access

@dipinknair dipinknair changed the title [TEST] Add vulnerability check ci: Add vulnerability check Oct 8, 2024
@dipinknair dipinknair marked this pull request as ready for review October 8, 2024 14:21
@dipinknair dipinknair requested a review from a team as a code owner October 8, 2024 14:21
@dipinknair dipinknair requested a review from RobPasMue October 8, 2024 14:21
Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dipinknair dipinknair merged commit c06d097 into main Oct 8, 2024
@dipinknair dipinknair deleted the feat/vulnerability branch October 8, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation enhancement New features or code improvements maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants