Skip to content

fix: merging coverage step in ci_cd#720

Merged
klmcadams merged 2 commits intomainfrom
fix/merge-coverage
Apr 25, 2024
Merged

fix: merging coverage step in ci_cd#720
klmcadams merged 2 commits intomainfrom
fix/merge-coverage

Conversation

@klmcadams
Copy link
Collaborator

Extra newline in the upload coverage-file-tests step caused "coverage-file-tests" to not be uploaded, which made merging coverage fail

@klmcadams klmcadams requested a review from a team as a code owner April 25, 2024 12:47
@codecov
Copy link

codecov bot commented Apr 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.08%. Comparing base (2e21178) to head (3fb33a3).

❗ Current head 3fb33a3 differs from pull request most recent head ed96b82. Consider uploading reports for the commit ed96b82 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #720      +/-   ##
==========================================
+ Coverage   77.03%   77.08%   +0.05%     
==========================================
  Files          31       31              
  Lines        1968     1968              
==========================================
+ Hits         1516     1517       +1     
+ Misses        452      451       -1     

@github-actions github-actions bot added maintenance Package and maintenance related CI/CD bug Something isn't working labels Apr 25, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Apr 25, 2024
@klmcadams klmcadams enabled auto-merge (squash) April 25, 2024 12:57
@klmcadams klmcadams merged commit b317374 into main Apr 25, 2024
@klmcadams klmcadams deleted the fix/merge-coverage branch April 25, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants