feat: Add test for deprecation warning #739
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koubaa
reviewed
May 20, 2024
koubaa
approved these changes
May 20, 2024
github-actions
bot
added
the
documentation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #739 +/- ##
==========================================
+ Coverage 81.01% 81.06% +0.04%
==========================================
Files 32 32
Lines 2002 2002
==========================================
+ Hits 1622 1623 +1
+ Misses 380 379 -1 |
koubaa
reviewed
May 20, 2024
| with pytest.warns(UserWarning): | ||
| struct.SystemID | ||
| harmonic_acoustic.SystemID | ||
| harmonic_acoustic.AnalysisSettings.MultipleRPMs = True |
Collaborator
There was a problem hiding this comment.
minor - putting both in a pytest.warns will technically allow the test to pass if one of these does not cause a deprecation warning. A better design would be to put each in its own pytest.warns block
Collaborator
Author
There was a problem hiding this comment.
I already merged this. But I will make these changes in the other PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add additional case for deprecation warning