Skip to content

fix lifetime issue - #768

Merged
koubaa merged 5 commits into
mainfrom
fix-app-lifetime
Jun 12, 2024
Merged

koubaa merged 5 commits into
mainfrom
fix-app-lifetime

Conversation

@koubaa

@koubaa koubaa commented Jun 12, 2024

Copy link
Copy Markdown
Contributor

and rework test assets folder

and rework test assets folder
@koubaa
koubaa requested a review from a team as a code owner June 12, 2024 19:12
@koubaa
koubaa requested review from dipinknair and klmcadams June 12, 2024 19:13
@github-actions github-actions Bot added the bug Something isn't working label Jun 12, 2024
@koubaa

koubaa commented Jun 12, 2024

Copy link
Copy Markdown
Contributor Author

@dipinknair after this lands, we should make a new release on pypi

@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Jun 12, 2024
Comment thread tests/assets/Eng157.x_t
@@ -67,4 +67,4 @@ T51 : TRANSMIT FILE created by modeller version 110015017 SCH_1100150_110040 12
50 93 61 0 53 0 88 0 +0 .0127 0 0 0 -1 -1 0 0 81 1 91 125 89 53 0 0 87 0 104 83
3 104 .752941176470588 .752941176470588 .752941176470588 83 3 92 .7529411764705

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dipinknair @klmcadams maybe this is OK but we probably should prevent the style precommits from changing CAD files like these parasolid ones

Comment thread tests/assets/cube-hole.mechdb
@koubaa
koubaa merged commit 9287f6d into main Jun 12, 2024
@koubaa
koubaa deleted the fix-app-lifetime branch June 12, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants