fix sharing app instances, clarify contract#784
Merged
Conversation
github-actions
Bot
added
the
documentation
added 3 commits
June 21, 2024 11:27
…s/pymechanical into fix-building-gallery-scopes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #784 +/- ##
==========================================
- Coverage 81.30% 81.00% -0.31%
==========================================
Files 32 32
Lines 2065 2074 +9
==========================================
+ Hits 1679 1680 +1
- Misses 386 394 +8 |
dipinknair
approved these changes
Jun 21, 2024
sbradrick
reviewed
Jun 26, 2024
| @@ -297,8 +297,8 @@ def _share(self, other) -> None: | |||
| they all point to the same underlying application | |||
| object. Because of that, special care needs to be | |||
| taken to properly share the state. Other will be | |||
Contributor
There was a problem hiding this comment.
they all point to the same underlying application object. As a result, you need to be careful to properly share the state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested with embedded examples - ansys/pymechanical-embedding-examples#203