Skip to content

Conversation

@dipinknair
Copy link
Collaborator

When building gallery only one instance of pymechanical app should be used.

@github-actions github-actions bot added the enhancement New features or code improvements label Jun 24, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jun 24, 2024
@codecov
Copy link

codecov bot commented Jun 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.11%. Comparing base (2076621) to head (734bfb2).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #787      +/-   ##
==========================================
+ Coverage   81.06%   81.11%   +0.04%     
==========================================
  Files          32       32              
  Lines        2086     2086              
==========================================
+ Hits         1691     1692       +1     
+ Misses        395      394       -1     

@dipinknair dipinknair marked this pull request as ready for review June 24, 2024 13:28
@dipinknair dipinknair requested a review from a team as a code owner June 24, 2024 13:28
@dipinknair dipinknair requested a review from koubaa June 24, 2024 13:28
Copy link
Collaborator

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do this in embedding_scripts, not embedding. We don't wanto to affect the test fixture behavior for embedding

@dipinknair dipinknair self-assigned this Jun 26, 2024
@dipinknair dipinknair linked an issue Jun 26, 2024 that may be closed by this pull request
@dipinknair dipinknair requested a review from koubaa June 26, 2024 14:53
@dipinknair dipinknair merged commit 171ca17 into main Jun 26, 2024
@dipinknair dipinknair deleted the feat/test-gallery branch June 26, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New features or code improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add test for BUILDING_GALLERY

5 participants