Skip to content

add background app class#849

Merged
koubaa merged 5 commits into
mainfrom
background-app
Aug 6, 2024
Merged

add background app class#849
koubaa merged 5 commits into
mainfrom
background-app

Conversation

@koubaa

@koubaa koubaa commented Aug 5, 2024

Copy link
Copy Markdown
Contributor

Mechanical isn't threadsafe, but this adds more user-friendliness to the Poster by managing a background thread, poster, and app instance in one place. This should be used in the rpyc branch

@koubaa koubaa requested review from dipinknair and klmcadams August 5, 2024 15:36
@koubaa koubaa requested a review from a team as a code owner August 5, 2024 15:36
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Aug 5, 2024
@codecov

codecov Bot commented Aug 5, 2024

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 37.73585% with 33 lines in your changes missing coverage. Please review.

Project coverage is 80.71%. Comparing base (999a671) to head (4957217).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #849      +/-   ##
==========================================
- Coverage   81.84%   80.71%   -1.14%     
==========================================
  Files          32       33       +1     
  Lines        2104     2157      +53     
==========================================
+ Hits         1722     1741      +19     
- Misses        382      416      +34     

@koubaa koubaa merged commit 97cb3b0 into main Aug 6, 2024
@koubaa koubaa deleted the background-app branch August 6, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants