Skip to content

FIX: Adapting breaking change for upload action - #895

Merged
dipinknair merged 2 commits into
mainfrom
fix/upload-artifact
Sep 5, 2024
Merged

dipinknair merged 2 commits into
mainfrom
fix/upload-artifact

Conversation

@dipinknair

Copy link
Copy Markdown
Contributor

with new release https://github.com/actions/upload-artifact/releases/tag/v4.4.0

include-hidden-files should be added for uploading hidden files. This is required for .cov files which are needed for testing coverage

@github-actions github-actions Bot added maintenance Package and maintenance related ci/cd Involves the GitHub workflow files bug Something isn't working labels Sep 5, 2024
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 5, 2024
@codecov

codecov Bot commented Sep 5, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.86%. Comparing base (cb8ba30) to head (da48d74).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   79.90%   79.86%   -0.05%     
==========================================
  Files          33       33              
  Lines        2155     2155              
==========================================
- Hits         1722     1721       -1     
- Misses        433      434       +1     

@dipinknair
dipinknair marked this pull request as ready for review September 5, 2024 20:20
@dipinknair
dipinknair requested a review from a team as a code owner September 5, 2024 20:20

@MaxJPRey MaxJPRey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@dipinknair
dipinknair merged commit cf3b0c5 into main Sep 5, 2024
@dipinknair
dipinknair deleted the fix/upload-artifact branch September 5, 2024 20:27
@RobPasMue

Copy link
Copy Markdown
Member

@dipinknair please sign up for next week and announce this to the larger dev meeting. I'm sure many will be affected

@PipKat PipKat changed the title FIX: Adapting braking change for upload action FIX: Adapting breaking change for upload action Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ci/cd Involves the GitHub workflow files documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants