FIX: Throw value error for unsupported version of Mechanical#917
Merged
Conversation
koubaa
reviewed
Sep 24, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #917 +/- ##
==========================================
- Coverage 85.30% 80.95% -4.36%
==========================================
Files 35 35
Lines 2226 2232 +6
==========================================
- Hits 1899 1807 -92
- Misses 327 425 +98 |
…ymechanical into fix/unsupported-versions
koubaa
reviewed
Sep 26, 2024
koubaa
requested changes
Sep 26, 2024
koubaa
reviewed
Sep 26, 2024
koubaa
approved these changes
Sep 27, 2024
koubaa
approved these changes
Sep 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed #913
if no version is provided to
App()takes the latest Mechanical version found in system and throws warning.In case of Linux,
mechanical-envensures only one version (either from saved path or latest version found in default installations directory) is found when checking AWP_ROOT env.