Skip to content

FIX: Throw value error for unsupported version of Mechanical#917

Merged
dipinknair merged 10 commits into
mainfrom
fix/unsupported-versions
Sep 30, 2024
Merged

FIX: Throw value error for unsupported version of Mechanical#917
dipinknair merged 10 commits into
mainfrom
fix/unsupported-versions

Conversation

@dipinknair
Copy link
Copy Markdown
Collaborator

@dipinknair dipinknair commented Sep 23, 2024

Fixed #913

if no version is provided to App() takes the latest Mechanical version found in system and throws warning.
In case of Linux, mechanical-env ensures only one version (either from saved path or latest version found in default installations directory) is found when checking AWP_ROOT env.

@dipinknair dipinknair requested a review from koubaa September 23, 2024 20:27
@github-actions github-actions Bot added the bug Something isn't working label Sep 23, 2024
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 23, 2024
Comment thread src/ansys/mechanical/core/embedding/initializer.py Outdated
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 26, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (f51a086) to head (8e687e2).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #917      +/-   ##
==========================================
- Coverage   85.30%   80.95%   -4.36%     
==========================================
  Files          35       35              
  Lines        2226     2232       +6     
==========================================
- Hits         1899     1807      -92     
- Misses        327      425      +98     

@dipinknair dipinknair marked this pull request as ready for review September 26, 2024 14:08
@dipinknair dipinknair requested a review from a team as a code owner September 26, 2024 14:08
@dipinknair dipinknair requested a review from koubaa September 26, 2024 14:08
Comment thread src/ansys/mechanical/core/embedding/initializer.py Outdated
Comment thread src/ansys/mechanical/core/embedding/initializer.py Outdated
Comment thread src/ansys/mechanical/core/embedding/initializer.py Outdated
Comment thread src/ansys/mechanical/core/embedding/initializer.py Outdated
Comment thread src/ansys/mechanical/core/embedding/resolver.py Outdated
@dipinknair dipinknair requested a review from koubaa September 27, 2024 18:37
@dipinknair dipinknair merged commit 225b52a into main Sep 30, 2024
@dipinknair dipinknair deleted the fix/unsupported-versions branch September 30, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Throw error if unsupported version of Mechanical is used with latest version of PyMechanical

3 participants