Skip to content

Conversation

@dipinknair
Copy link
Collaborator

catch some of the exceptions, use error handling instead of assert.

@dipinknair dipinknair marked this pull request as ready for review October 8, 2024 15:56
@dipinknair dipinknair requested a review from a team as a code owner October 8, 2024 15:56
@github-actions github-actions bot added the maintenance Package and maintenance related label Oct 8, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 8, 2024
@codecov
Copy link

codecov bot commented Oct 8, 2024

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.88%. Comparing base (a04e8be) to head (2686803).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #937      +/-   ##
==========================================
- Coverage   85.25%   80.88%   -4.38%     
==========================================
  Files          35       35              
  Lines        2232     2234       +2     
==========================================
- Hits         1903     1807      -96     
- Misses        329      427      +98     

Copy link
Member

@RobPasMue RobPasMue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dipinknair dipinknair merged commit a4537bf into main Oct 9, 2024
@dipinknair dipinknair deleted the maint/code-maint branch October 9, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants