Skip to content

chore: code maintenance #947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dipinknair merged 7 commits into from
Oct 16, 2024
Merged

chore: code maintenance #947

dipinknair merged 7 commits into from
Oct 16, 2024

Conversation

@dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Oct 15, 2024 •
edited
Loading

  • Use runtime error instead of assert
  • Update downloading process

@github-actions github-actions bot added the bug Something isn't working label Oct 15, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 15, 2024
@dipinknair dipinknair marked this pull request as ready for review October 16, 2024 14:35
@dipinknair dipinknair requested a review from a team as a code owner October 16, 2024 14:35
@github-actions github-actions bot added the dependencies Related with project dependencies label Oct 16, 2024
@dipinknair dipinknair requested a review from RobPasMue October 16, 2024 14:50
@codecov
Copy link

codecov bot commented Oct 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 66.66667% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.94%. Comparing base (2cf726e) to head (d1ef55a).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #947      +/-   ##
==========================================
- Coverage   81.02%   80.94%   -0.09%     
==========================================
  Files          36       36              
  Lines        2272     2278       +6     
==========================================
+ Hits         1841     1844       +3     
- Misses        431      434       +3

@dipinknair dipinknair merged commit baaa546 into main Oct 16, 2024
@dipinknair dipinknair deleted the fix/securities branch October 16, 2024 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@klmcadams klmcadams klmcadams approved these changes

@RobPasMue RobPasMue Awaiting requested review from RobPasMue

Assignees

No one assigned

Labels

bug Something isn't working dependencies Related with project dependencies documentation Improvements or additions to documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dipinknair @klmcadams @pyansys-ci-bot