Skip to content

Conversation

@klmcadams
Copy link
Collaborator

  • Change pass to raise Exception
  • Add # no sec lines to subprocesses where the arguments are known/valid
  • Remove shell=True from subprocess

@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
@codecov
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.19%. Comparing base (4153cc3) to head (2e34633).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
- Coverage   85.39%   81.19%   -4.21%     
==========================================
  Files          36       36              
  Lines        2308     2302       -6     
==========================================
- Hits         1971     1869     -102     
- Misses        337      433      +96     

@klmcadams klmcadams requested a review from RobPasMue October 17, 2024 17:30
@klmcadams klmcadams marked this pull request as ready for review October 17, 2024 18:10
@klmcadams klmcadams requested a review from a team as a code owner October 17, 2024 18:10
@klmcadams klmcadams requested review from RobPasMue and koubaa October 22, 2024 21:46
@klmcadams klmcadams requested review from koubaa and removed request for koubaa October 24, 2024 14:24
@klmcadams klmcadams merged commit b95edcf into main Oct 28, 2024
50 checks passed
@klmcadams klmcadams deleted the fix/bandit-recos branch October 28, 2024 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants