Skip to content

feat: Add overwrite option for App.save_as()#951

Merged
dipinknair merged 11 commits intomainfrom
fix/save_as
Oct 22, 2024
Merged

feat: Add overwrite option for App.save_as()#951
dipinknair merged 11 commits intomainfrom
fix/save_as

Conversation

@dipinknair
Copy link
Collaborator

@dipinknair dipinknair commented Oct 17, 2024

deletes existing files so that new files can be saved in that location

Closes #900

@dipinknair dipinknair marked this pull request as ready for review October 17, 2024 18:42
@dipinknair dipinknair requested a review from a team as a code owner October 17, 2024 18:42
@github-actions github-actions bot added the bug Something isn't working label Oct 17, 2024
@dipinknair dipinknair requested a review from koubaa October 17, 2024 18:42
@dipinknair dipinknair requested a review from klmcadams October 17, 2024 18:42
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Oct 17, 2024
@dipinknair dipinknair requested a review from koubaa October 18, 2024 15:12
@dipinknair dipinknair requested a review from koubaa October 22, 2024 13:49
@codecov
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.15%. Comparing base (4acf478) to head (46b1b9d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   81.05%   81.15%   +0.09%     
==========================================
  Files          36       36              
  Lines        2280     2292      +12     
==========================================
+ Hits         1848     1860      +12     
  Misses        432      432              

Copy link
Collaborator

@koubaa koubaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see other comments

@dipinknair dipinknair requested a review from koubaa October 22, 2024 15:14
@dipinknair dipinknair enabled auto-merge (squash) October 22, 2024 16:08
@dipinknair dipinknair merged commit 43ff322 into main Oct 22, 2024
@dipinknair dipinknair deleted the fix/save_as branch October 22, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add overwrite option to save_as()

3 participants