FEAT: Update private app data creation and add tests - #986
Merged
Conversation
github-actions
Bot
added
the
documentation
…ansys/pymechanical into feat/add-test-uniqueuserprofile
dipinknair
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 86.87% 83.47% -3.40%
==========================================
Files 35 35
Lines 2255 2257 +2
==========================================
- Hits 1959 1884 -75
- Misses 296 373 +77
|
dipinknair
marked this pull request as ready for review
November 20, 2024 03:08
klmcadams
requested changes
Nov 20, 2024
klmcadams
left a comment
klmcadams
left a comment
Contributor
There was a problem hiding this comment.
Overall, this looks good! I suggested to use pathlib.Path over os since the pathlib library is the new standard and added a couple docstrings to the test functions
Co-authored-by: Kerry McAdams <58492561+klmcadams@users.noreply.github.com>
…ansys/pymechanical into feat/add-test-uniqueuserprofile
…ansys/pymechanical into feat/add-test-uniqueuserprofile
…ansys/pymechanical into feat/add-test-uniqueuserprofile
klmcadams
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eg:
App(private_appdata=True, copy_profile=False)~45% increase in coverage