Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand added the enhancement New features or code improvements label Aug 14, 2024
@ansnfernand ansnfernand requested a review from ansjmoody August 14, 2024 09:15
@ansnfernand ansnfernand self-assigned this Aug 14, 2024
@github-actions github-actions bot added the testing Anything related to tests label Aug 14, 2024
@codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 34.45378% with 78 lines in your changes missing coverage. Please review.

Project coverage is 56.77%. Comparing base (74587d9) to head (2066117).
Report is 1 commits behind head on main.

Files Patch % Lines
src/ansys/sherlock/core/layer.py 30.00% 77 Missing ⚠️
src/ansys/sherlock/core/errors.py 88.88% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #363      +/-   ##
==========================================
- Coverage   57.21%   56.77%   -0.45%     
==========================================
  Files          21       21              
  Lines        4434     4541     +107     
==========================================
+ Hits         2537     2578      +41     
- Misses       1897     1963      +66     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansjmoody ansjmoody merged commit cdd4552 into main Aug 16, 2024
@ansjmoody ansjmoody deleted the updateModelingRegion branch August 16, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pySherlock API for add, update, copy and delete modeling regions

3 participants