Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Checklist:

  • Run unit tests and make sure they all pass
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running and can be connected to using gRPC

@ansnfernand ansnfernand added the enhancement New features or code improvements label Sep 12, 2024
@ansnfernand ansnfernand self-assigned this Sep 12, 2024
@github-actions github-actions bot added the testing Anything related to tests label Sep 12, 2024
@codecov
Copy link

codecov bot commented Sep 12, 2024

Codecov Report

Attention: Patch coverage is 65.62500% with 11 lines in your changes missing coverage. Please review.

Project coverage is 56.98%. Comparing base (1f93594) to head (1db0256).

Files with missing lines Patch % Lines
src/ansys/sherlock/core/layer.py 59.25% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #379      +/-   ##
==========================================
+ Coverage   56.92%   56.98%   +0.06%     
==========================================
  Files          21       21              
  Lines        4601     4633      +32     
==========================================
+ Hits         2619     2640      +21     
- Misses       1982     1993      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ansnfernand ansnfernand merged commit 1b47d8f into main Sep 16, 2024
@ansnfernand ansnfernand deleted the deleteModeling branch September 16, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add pySherlock API for add, update, copy and delete modeling regions

3 participants