Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Description

Fix this issue: <google.protobuf.internal.enum_type_wrapper.EnumTypeWrapper object at 0x00000258FFE21B10> is not a Python type (it may be an instance of an object), Pydantic will allow any object with no validation since we cannot even enforce that the input is an instance of the given type. To get rid of this error wrap the type with pydantic.SkipValidation.

Issue linked

#617

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • [] Bench test new/modified APIs by using and modifying the code in the example for the API method
  • [] Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Sep 8, 2025
@ansnfernand ansnfernand self-assigned this Sep 8, 2025
@ansnfernand ansnfernand added the enhancement New features or code improvements label Sep 8, 2025
@github-actions github-actions bot added testing Anything related to tests bug Something isn't working labels Sep 8, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 61.51%. Comparing base (cd237c6) to head (73c0fbb).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #635      +/-   ##
==========================================
+ Coverage   61.46%   61.51%   +0.05%     
==========================================
  Files          22       22              
  Lines        5878     5878              
==========================================
+ Hits         3613     3616       +3     
+ Misses       2265     2262       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansjmoody ansjmoody merged commit 4487b53 into main Sep 8, 2025
27 checks passed
@ansjmoody ansjmoody deleted the fixImportsToAVL branch September 8, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working documentation Improvements or additions to documentation enhancement New features or code improvements testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants