Skip to content

Conversation

@ansnfernand
Copy link
Collaborator

Description

fix: updated get_stackup_props() to have improveStackupModelEnabled in the response

Issue linked

#668

Checklist:

  • Run unit tests and make sure they all pass
    - Run tests without Sherlock running
    - Run tests with Sherlock GRPC connection
  • Check and fix style errors
    - pre-commit command line check
    - Problems tab in PyCharm
  • Bench test new/modified APIs by using and modifying the code in the example for the API method
  • Add new classes to rst files, located at: \doc\source\api
  • Generate documentation
  • Verify the HTML. It gets generated at: \doc\build\html.
    - Open index.html
    - Click on "API Reference" at the top.
    - Verify HTML for API changes.
  • Check that test code coverage is at least 80% when Sherlock is running
  • Check vulnerabilities locally
  • Make sure that the title of the pull request follows Commit naming conventions (e.g. feat: adding new PySherlock command)

@ansnfernand ansnfernand added this to the 2026 R1 milestone Nov 18, 2025
@ansnfernand ansnfernand self-assigned this Nov 18, 2025
@ansnfernand ansnfernand added the bug Something isn't working label Nov 18, 2025
@github-actions github-actions bot added the testing Anything related to tests label Nov 18, 2025
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Nov 18, 2025
@codecov
Copy link

codecov bot commented Nov 18, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.99%. Comparing base (45f79fc) to head (906c48d).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ansys/sherlock/core/types/stackup_types.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #669      +/-   ##
==========================================
- Coverage   63.00%   62.99%   -0.02%     
==========================================
  Files          22       22              
  Lines        6196     6197       +1     
==========================================
  Hits         3904     3904              
- Misses       2292     2293       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ansnfernand ansnfernand enabled auto-merge (squash) November 20, 2025 15:31
@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related labels Nov 20, 2025
@ansnfernand ansnfernand merged commit d34a9b2 into main Nov 20, 2025
26 of 28 checks passed
@ansnfernand ansnfernand deleted the nayane/fixGetStackupProps branch November 20, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related testing Anything related to tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants