From 3161a4cbab1c88bb6ff54a7fc53045a9a1078b5a Mon Sep 17 00:00:00 2001 From: Nayane Fernandes <143632290+ansnfernand@users.noreply.github.com> Date: Tue, 18 Nov 2025 17:39:19 +0100 Subject: [PATCH 1/5] fix: updated get_stackup_props() to have improveStackupModelEnabled in the response --- .../sherlock/core/types/stackup_types.py | 1 + tests/test_stackup.py | 38 ++++++++++++++----- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/src/ansys/sherlock/core/types/stackup_types.py b/src/ansys/sherlock/core/types/stackup_types.py index f35b1e204..3e1aeb5c1 100644 --- a/src/ansys/sherlock/core/types/stackup_types.py +++ b/src/ansys/sherlock/core/types/stackup_types.py @@ -20,3 +20,4 @@ def __init__(self, properties: SherlockStackupService_pb2.GetStackupPropsRespons self.ctez = properties.ctEz self.exy = properties.exy self.ez = properties.ez + self.improve_stackup_model_enabled = properties.improveStackupModelEnabled diff --git a/tests/test_stackup.py b/tests/test_stackup.py index 4648008a7..4792133c8 100644 --- a/tests/test_stackup.py +++ b/tests/test_stackup.py @@ -611,16 +611,34 @@ def helper_test_get_stackup_props(stackup): "Main Board", ) - assert ( - stackup_properties.board_dimension == "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]" - ), "Board dimension" - assert stackup_properties.board_thickness == "2.091 mm [82.3 mil]", "Board thickness" - assert stackup_properties.density == "2.0264 g/cc", "Density" - assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count" - assert stackup_properties.ctexy == "18.618 ppm/C", "CTExy" - assert stackup_properties.ctez == "60.821 ppm/C", "CTEz" - assert stackup_properties.exy == "25,420 MPa", "Exy" - assert stackup_properties.ez == "6,939 MPa", "Ez" + if stackup_properties.improve_stackup_model_enabled: + assert ( + stackup_properties.board_dimension + == "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]" + ), "Board dimension" + assert ( + stackup_properties.board_thickness == "2.091 mm [82.3 mil]" + ), "Board thickness" + assert stackup_properties.density == "2.0264 g/cc", "Density" + assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count" + assert stackup_properties.ctexy == "18.556 ppm/C", "CTExy" + assert stackup_properties.ctez == "60.821 ppm/C", "CTEz" + assert stackup_properties.exy == "24,865 MPa", "Exy" + assert stackup_properties.ez == "6,939 MPa", "Ez" + else: + assert ( + stackup_properties.board_dimension + == "190.3171 x 114.3076 mm [7.4928 x 4.5003 in]" + ), "Board dimension" + assert ( + stackup_properties.board_thickness == "2.091 mm [82.3 mil]" + ), "Board thickness" + assert stackup_properties.density == "2.0264 g/cc", "Density" + assert stackup_properties.conductor_layers_cnt == "6", "Conductor layers count" + assert stackup_properties.ctexy == "18.618 ppm/C", "CTExy" + assert stackup_properties.ctez == "60.821 ppm/C", "CTEz" + assert stackup_properties.exy == "25,420 MPa", "Exy" + assert stackup_properties.ez == "6,939 MPa", "Ez" except SherlockGetLayerCountError as e: pytest.fail(str(e)) From 8b3420c48cf85e9c4472f637cdb985810de87e80 Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 18 Nov 2025 16:48:14 +0000 Subject: [PATCH 2/5] chore: adding changelog file 669.miscellaneous.md [dependabot-skip] --- doc/changelog.d/669.miscellaneous.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 doc/changelog.d/669.miscellaneous.md diff --git a/doc/changelog.d/669.miscellaneous.md b/doc/changelog.d/669.miscellaneous.md new file mode 100644 index 000000000..1cde8c547 --- /dev/null +++ b/doc/changelog.d/669.miscellaneous.md @@ -0,0 +1 @@ +Fix: updated get_stackup_props() to have improveStackupModelEnabled in the response From fa99ad61a5d41ec4f6e17a4bf3a5002d098de2af Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Tue, 18 Nov 2025 16:51:56 +0000 Subject: [PATCH 3/5] chore: adding changelog file 669.test.md [dependabot-skip] --- doc/changelog.d/{669.miscellaneous.md => 669.test.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename doc/changelog.d/{669.miscellaneous.md => 669.test.md} (100%) diff --git a/doc/changelog.d/669.miscellaneous.md b/doc/changelog.d/669.test.md similarity index 100% rename from doc/changelog.d/669.miscellaneous.md rename to doc/changelog.d/669.test.md From eaf507625242c5ece4e0e5db805a1e23bf1d5757 Mon Sep 17 00:00:00 2001 From: Nayane Fernandes <143632290+ansnfernand@users.noreply.github.com> Date: Thu, 20 Nov 2025 16:31:15 +0100 Subject: [PATCH 4/5] bumped ansys-api-sherlock to 0.1.52 --- pyproject.toml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyproject.toml b/pyproject.toml index a74bf772c..117bb9aea 100644 --- a/pyproject.toml +++ b/pyproject.toml @@ -24,7 +24,7 @@ classifiers = [ ] dependencies = [ - "ansys-api-sherlock==0.1.51", + "ansys-api-sherlock==0.1.52", "grpcio>=1.17, <1.68.0", "protobuf>=3.20", "pydantic>=2.9.2", From 906c48db2c5e5e64873c5686de12b7c917c03fdb Mon Sep 17 00:00:00 2001 From: pyansys-ci-bot <92810346+pyansys-ci-bot@users.noreply.github.com> Date: Thu, 20 Nov 2025 15:32:35 +0000 Subject: [PATCH 5/5] chore: adding changelog file 669.documentation.md [dependabot-skip] --- doc/changelog.d/{669.test.md => 669.documentation.md} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename doc/changelog.d/{669.test.md => 669.documentation.md} (100%) diff --git a/doc/changelog.d/669.test.md b/doc/changelog.d/669.documentation.md similarity index 100% rename from doc/changelog.d/669.test.md rename to doc/changelog.d/669.documentation.md