diff --git a/doc/changelog.d/671.test.md b/doc/changelog.d/671.test.md new file mode 100644 index 000000000..12d79783e --- /dev/null +++ b/doc/changelog.d/671.test.md @@ -0,0 +1 @@ +Fix: fixed unit tests diff --git a/src/ansys/sherlock/core/common.py b/src/ansys/sherlock/core/common.py index 9a5c8ff0f..d5056ed2f 100644 --- a/src/ansys/sherlock/core/common.py +++ b/src/ansys/sherlock/core/common.py @@ -145,10 +145,10 @@ def list_solder_materials(self) -> list[str]: if not self._is_connection_up(): raise SherlockNoGrpcConnectionException() - request = SherlockCommonService_pb2.GetSoldersRequest() - response = self.stub.getSolders(request) + request = SherlockCommonService_pb2.SolderInfoRequest() + response = self.stub.getSolderInfo(request) - return response.solderName + return response.solders @require_version(251) def get_sherlock_info(self) -> str: diff --git a/src/ansys/sherlock/core/errors.py b/src/ansys/sherlock/core/errors.py index 930c14e80..cf1c2d7e9 100644 --- a/src/ansys/sherlock/core/errors.py +++ b/src/ansys/sherlock/core/errors.py @@ -224,13 +224,17 @@ def str_itr(self): class SherlockAddRandomVibeEventError(Exception): """Contains the errors raised when a random vibe event cannot be added.""" - def __init__(self, message: str): + def __init__(self, message: Optional[str] = None, error_array: Optional[list[str]] = None): """Initialize error message.""" self.message = message + self.error_array = error_array def str_itr(self): """Create list of error messages.""" - if self.message is not None: + if self.error_array is not None: + return [f"Add random vibe event error: {error}" for error in self.error_array] + + elif self.message is not None: return [f"Add random vibe event error: {self.message}"] diff --git a/tests/test_lifecycle.py b/tests/test_lifecycle.py index f672e92b9..7fec64c93 100644 --- a/tests/test_lifecycle.py +++ b/tests/test_lifecycle.py @@ -2257,6 +2257,7 @@ def helper_test_load_harmonic_profile(lifecycle: Lifecycle): "Phase 1", "Harmonic Event", "Test_Profile.dat", + "x", ) pytest.fail("No exception raised when using an invalid parameter") except Exception as e: diff --git a/tests/test_parts.py b/tests/test_parts.py index a563ea504..0fa90b420 100644 --- a/tests/test_parts.py +++ b/tests/test_parts.py @@ -159,7 +159,7 @@ def helper_test_update_parts_from_AVL(parts: Parts): avl_description=AVLDescription.ASSIGN_APPROVED_DESCRIPTION, ) - assert response.returnCode.value == 0 + assert response == 0 except SherlockUpdatePartsFromAVLError as e: pytest.fail(e.message)