fix: missing get method for optical properties - #434
Merged
Conversation
added 4 commits
January 30, 2025 20:45
…_template_link or _material_instance Signed-off-by: plu <plu@ansys.com>
Signed-off-by: plu <plu@ansys.com>
Signed-off-by: plu <plu@ansys.com>
…p comes after the vop_guid in the property list Signed-off-by: plu <plu@ansys.com>
pluAtAnsys
requested review from
Revathyvenugopal162,
echambla,
etiennearnal and
jomadec
as code owners
January 30, 2025 20:54
pluAtAnsys
commented
Jan 30, 2025
…imilarity ratio Signed-off-by: plu <plu@ansys.com>
echambla
reviewed
Jan 31, 2025
Co-authored-by: Elodie Chamblas <100407563+echambla@users.noreply.github.com>
pluAtAnsys
changed the title
echambla
previously approved these changes
Feb 10, 2025
echambla
reviewed
Feb 10, 2025
echambla
left a comment
echambla
left a comment
Collaborator
There was a problem hiding this comment.
Make sure all steps of the CI/CD are ok
echambla
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid using the vop_template_link, sop_template_link, or hidden method _material_instance to get property geometries info