Skip to content

MAINT: get version value dynamically #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2023
Merged

MAINT: get version value dynamically #58

merged 1 commit into from
Jan 13, 2023

Conversation

@jorgepiloto
Copy link
Member

@jorgepiloto jorgepiloto commented Jan 12, 2023

Fix #57 by reading the version value from the __init__.py file. This allows to no longer depend on the importlib-metadata library.

@jorgepiloto jorgepiloto requested a review from a team January 12, 2023 16:53
@github-actions github-actions bot added the maintenance Generic maintenance related label Jan 12, 2023
MaxJPRey
MaxJPRey approved these changes Jan 12, 2023
View reviewed changes
Copy link
Contributor

@MaxJPRey MaxJPRey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@jorgepiloto
Copy link
Member Author

jorgepiloto commented Jan 13, 2023

Thanks for the review, @MaxJPRey. Merging this 🚀

@jorgepiloto jorgepiloto merged commit 7ae653e into main Jan 13, 2023
@jorgepiloto jorgepiloto deleted the maint/dynamic-version branch January 13, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaxJPRey MaxJPRey MaxJPRey approved these changes

Assignees

No one assigned

Labels

maintenance Generic maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Set up dynamic version to avoid depending on importlib-metadata

3 participants

@jorgepiloto @MaxJPRey