-
Notifications
You must be signed in to change notification settings - Fork 4
MAINT: migrate code linters to ruff #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aed2d4d to
ac75dbd
Compare
duposyl
reviewed
Feb 1, 2023
77e906c to
c6584d5
Compare
MaxJPRey
reviewed
Feb 6, 2023
Contributor
MaxJPRey
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! I will use it in PyAEDT, as soon as I am done with the pyproject.toml migration.
MaxJPRey
reviewed
Feb 6, 2023
df17153 to
74c8bcd
Compare
95ffba7 to
7346344
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #67 by implementing ruff for unifying
flake8,isort,pep8-naming, andpydocstyle.This is also a good oportunity to identify the style errors we are getting. The following command allows to filer and count these errors:
ruff . | awk '{print $2}' | sort | uniqWith current style ignores, the following
rufferrors are present:Filter out particular errors by running:
ruff . | grep "<ERROR NAME>"Some of the previous issues are easy to fix while others are not.
This pull-request is related with the main issue #6.