Skip to content

ci(security): general improvements - #802

Merged
duposyl merged 14 commits into
mainfrom
ci/security
Sep 3, 2025
Merged

ci(security): general improvements#802
duposyl merged 14 commits into
mainfrom
ci/security

Conversation

@jorgepiloto

@jorgepiloto jorgepiloto commented Aug 28, 2025

Copy link
Copy Markdown
Member

Fix #607 by enabling the security reports now that the project is public. It also uses SHA for tracking actions versions. Finally, an actions-style job runs zizmor to check for potential issues in the actions.

@jorgepiloto
jorgepiloto requested a review from a team as a code owner August 28, 2025 12:25
@github-actions github-actions Bot added the ci Pipelines maintenance related label Aug 28, 2025
duposyl
duposyl previously approved these changes Aug 28, 2025

@duposyl duposyl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

duposyl
duposyl previously approved these changes Aug 28, 2025
@jorgepiloto

Copy link
Copy Markdown
Member Author

Checking locally why this is failing. It is strange because we were running these and no issues were raised before.

@jorgepiloto

Copy link
Copy Markdown
Member Author

Following the instructions from the vulnerability actions and after running this locally, no errors were found by bandit or safety.

@jorgepiloto

Copy link
Copy Markdown
Member Author

I am suspecting about some permissions to access the security issues.

@jorgepiloto jorgepiloto changed the title ci(security): enable reports ci(security): enable reports and pin action versions using SHA Sep 1, 2025
@github-actions github-actions Bot added the style:code Improvements related to code style label Sep 2, 2025
@jorgepiloto
jorgepiloto force-pushed the ci/security branch 5 times, most recently from ce96d9b to 91b7b68 Compare September 3, 2025 07:48
@jorgepiloto jorgepiloto changed the title ci(security): enable reports and pin action versions using SHA ci(security): general improvements Sep 3, 2025
@codecov-commenter

codecov-commenter commented Sep 3, 2025

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.70%. Comparing base (835b5e7) to head (c529991).
⚠️ Report is 133 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #802      +/-   ##
==========================================
- Coverage   89.70%   89.70%   -0.01%     
==========================================
  Files          67       67              
  Lines      188022   188022              
  Branches     1339     1339              
==========================================
- Hits       168664   168662       -2     
- Misses      18965    18967       +2     
  Partials      393      393              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@duposyl duposyl left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for improving this!

@duposyl
duposyl merged commit b8b2ce4 into main Sep 3, 2025
58 checks passed
@duposyl
duposyl deleted the ci/security branch September 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ci Pipelines maintenance related style:code Improvements related to code style

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-enable ansys/actions/vulnerabilities

4 participants