fix: make WMI windows only dependency#105
Merged
Merged
Conversation
github-actions
Bot
added
dependencies
chrisg564
marked this pull request as ready for review
July 22, 2024 13:27
Contributor
|
There is a small ci cd fails, because we are following convention commits for the PR heading. i can fix it quickly. Thank you for the PR @chrisg564 . Pinging @jorgepiloto and @franknli for visibility |
Revathyvenugopal162
changed the title
WMI windows only dependency
franknli
approved these changes
Aug 8, 2024
Revathyvenugopal162
approved these changes
Aug 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For Ansys Notebook this package doesn't resolve because it can't find pywin32 that satisfies a linux env. This stems from WMI being a dependency that requires pywin32 on all platforms. This PR makes WMI a windows only requirement.
Fixes issue #100