Skip to content

support launching workbench in non-UI mode - #118

Merged
franknli merged 7 commits into
mainfrom
fli/support_non_ui_launch
Sep 11, 2024
Merged

support launching workbench in non-UI mode#118
franknli merged 7 commits into
mainfrom
fli/support_non_ui_launch

Conversation

@franknli

Copy link
Copy Markdown
Collaborator

No description provided.

@franknli
franknli requested review from a team and PipKat as code owners September 11, 2024 16:37
@github-actions github-actions Bot added the documentation Improvements or additions to documentation label Sep 11, 2024

def launch_workbench(
release="242", client_workdir=None, server_workdir=None, host=None, username=None, password=None
no_ui=False,

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't we place this new parameter at the end for compatibility with calls that do not use named parameters?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Positional parameters are NOT recommended. And all of the parameters are actually optional.

@franknli
franknli merged commit ea1541b into main Sep 11, 2024
@franknli
franknli deleted the fli/support_non_ui_launch branch September 11, 2024 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants