support variables in script; change argument release to version#143
Merged
Conversation
…variables' into fli/support_script_variables
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
asawas
reviewed
Oct 21, 2024
| Variables in the script specified as $$varname%%50%% will be converted to variable | ||
| values or use the default value - 50 in the example. | ||
| log_level : str, default: "error" | ||
| Level of logging. Options are "critical" "debug", "error", "info", and "warning". |
Collaborator
There was a problem hiding this comment.
Options are "critical", "debug", "error", "info", and "warning".
add a comma between "critical" and "debug". Also the same on line 150
asawas
reviewed
Oct 21, 2024
| self, | ||
| show_gui=True, | ||
| release="242", | ||
| version="242", |
Collaborator
There was a problem hiding this comment.
Do we want to update the default version to "251" ?
asawas
approved these changes
Oct 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.