support downloading project archive; suppress console window#145
Merged
support downloading project archive; suppress console window#145
Conversation
github-actions
bot
added
the
documentation
…nload' into fli/archive_and_download
…nload' into fli/archive_and_download
Revathyvenugopal162
changed the title
asawas
reviewed
Oct 23, 2024
| self._wmi_connection = None | ||
| self._process_id = -1 | ||
|
|
||
| if not version: |
Collaborator
There was a problem hiding this comment.
why not to keep the default argument value?
Collaborator
Author
There was a problem hiding this comment.
It is one of the requirements from ACE to use None as default, to be consistent with other PyAnsys products.
PipKat
reviewed
Oct 23, 2024
| client.upload_file_from_example_repo("pymechanical-integration/agdb/two_pipes.agdb") | ||
|
|
||
| There is a convenience function to save the current Workbench project on the server, archive | ||
| the project, then download the project archive to the client. |
Member
There was a problem hiding this comment.
Suggested change
| the project, then download the project archive to the client. | |
| the project, and then download the project archive to the client. |
PipKat
reviewed
Oct 23, 2024
| Parameters | ||
| ---------- | ||
| archive_name : str | ||
| The name of the project archive to use, without the file extension. |
Member
There was a problem hiding this comment.
Suggested change
| The name of the project archive to use, without the file extension. | |
| Name of the project archive to use, without the file extension. |
Ansys style is to omit the leading article in the brief description so that it always starts with an important word.
Collaborator
Author
There was a problem hiding this comment.
That makes sense. Updated.
PipKat
approved these changes
Oct 23, 2024
asawas
reviewed
Oct 23, 2024
| Whether to show a progress bar during the download. | ||
| """ | ||
| if not re.match(r"^\w+$", archive_name): | ||
| logging.error("archive name contains illegal character") |
Collaborator
There was a problem hiding this comment.
I suggest showing a clear message of what is the acceptable file name.
Collaborator
Author
There was a problem hiding this comment.
Updated the message.
asawas
approved these changes
Oct 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.