Skip to content

docs: update the common pyansys documents #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jorgepiloto merged 23 commits into from
May 24, 2024
Merged

docs: update the common pyansys documents #64

jorgepiloto merged 23 commits into from
May 24, 2024

Conversation

@Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented May 17, 2024 •
edited
Loading

This PR is for:
fixes #65

@wiz-inc-2dcf8239e9
Copy link

wiz-inc-2dcf8239e9 bot commented May 17, 2024 •
edited
Loading

Wiz Scan Summary
IaC Misconfigurations 0C 0H 0M 0L 0I
Vulnerabilities 0C 0H 0M 0L 0I
Sensitive Data 0C 0H 0M 0L 0I
Total 0C 0H 0M 0L 0I
Secrets 2🔑

@github-actions github-actions bot added dependencies Related with project dependencies maintenance Package and maintenance related documentation Improvements or additions to documentation labels May 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 17, 2024
jorgepiloto
jorgepiloto approved these changes May 17, 2024
View reviewed changes
Copy link
Member

@jorgepiloto jorgepiloto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding these, @Revathyvenugopal162.

@jorgepiloto
Copy link
Member

jorgepiloto commented May 17, 2024

Could you add a new CODEOWNERS file, @Revathyvenugopal162? It would be great if we could also create a PyWorkbench team (if it does not already exist).

@Revathyvenugopal162
Copy link
Contributor Author

Revathyvenugopal162 commented May 17, 2024

Could you add a new CODEOWNERS file, @Revathyvenugopal162? It would be great if we could also create a PyWorkbench team (if it does not already exist).

sure.

@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 17, 2024
@Revathyvenugopal162 Revathyvenugopal162 marked this pull request as ready for review May 17, 2024 14:34
@github-actions github-actions bot removed the documentation Improvements or additions to documentation label May 17, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 22, 2024
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 22, 2024
@Revathyvenugopal162 Revathyvenugopal162 mentioned this pull request May 22, 2024
Closed
10 tasks
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 22, 2024
PipKat
PipKat reviewed May 22, 2024
View reviewed changes
PipKat
PipKat reviewed May 22, 2024
View reviewed changes
PipKat
PipKat reviewed May 22, 2024
View reviewed changes
PipKat
PipKat reviewed May 22, 2024
View reviewed changes
PipKat
PipKat reviewed May 22, 2024
View reviewed changes
PipKat
PipKat approved these changes May 22, 2024
View reviewed changes
Copy link
Member

@PipKat PipKat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor edits are suggested.

@Revathyvenugopal162 @PipKat
Apply suggestions from code review
5253a72 
Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com>
@github-actions github-actions bot added documentation Improvements or additions to documentation and removed documentation Improvements or additions to documentation labels May 23, 2024
@Revathyvenugopal162
Copy link
Contributor Author

Revathyvenugopal162 commented May 23, 2024

Thank you @jorgepiloto and @PipKat for your review.

@jorgepiloto jorgepiloto merged commit aa47fd1 into main May 24, 2024
@jorgepiloto jorgepiloto deleted the docs/update-common-docs branch May 24, 2024 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jorgepiloto jorgepiloto jorgepiloto approved these changes

@PipKat PipKat PipKat approved these changes

@franknli franknli Awaiting requested review from franknli

Assignees

No one assigned

Labels

dependencies Related with project dependencies documentation Improvements or additions to documentation maintenance Package and maintenance related

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Improve README.md file

4 participants

@Revathyvenugopal162 @jorgepiloto @PipKat @pyansys-ci-bot