Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Carousel supports vertical #38

Merged
merged 2 commits into from
Jul 5, 2018

Conversation

jlsnake
Copy link
Contributor

@jlsnake jlsnake commented Jun 25, 2018

For this issue #26 and fix the selectedIndex display error in issue #7

  • Make sure that you follow antd's code convention.
  • Run npm run lint and fix those errors before submitting in order to keep consistent code style.
  • Rebase before creating a PR to keep commit history clear.
  • Add some descriptions and refer relative issues for you PR.

Extra checklist:

isNewFeature :

  • Update API docs for the component.
  • Update/Add demo to demonstrate new feature.
  • Update TypeScript definition for the component.
  • Add unit tests for the feature.

@warmhug
Copy link
Contributor

warmhug commented Jul 5, 2018

It seems that there is a drag problem on Android 4.1

But it works well on Android 7 and iOS. Thank you for your great work!

@warmhug
Copy link
Contributor

warmhug commented Jul 5, 2018

Close #26

This was referenced Jul 5, 2018
Reduce the height and avoid small screen mobile phone overflow
@warmhug warmhug merged commit a9b394b into ant-design:master Jul 5, 2018
@youngjuning
Copy link

但是还是有问题啊,竖屏的时候,初始化显示会有问题

@jlsnake
Copy link
Contributor Author

jlsnake commented Jul 26, 2018

什么问题?

@xiaohuoni
Copy link
Member

类似这种使用方式,可以规避掉,初始化显示的问题,还有不会 autoplay 的问题。

{data&&<Carousel/>}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants